ui: add compaction/flushes to storage graphs #25428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Knowing whether compactions are going on is helpful when diagnosing I/O performance problems. Release note (admin ui change): Add RocksDB compactions/flushes to storage graphs.
|
This change is |
a-robinson
approved these changes
May 11, 2018
|
Agreed. One step at a time. Arguably this is a problem with any individual duration for which the contributions usually span multiple metric reporting intervals. We'd need a better API that keeps tallying up the duration as it happens, perhaps taking a closure to be measured as its argument. |
|
bors r=a-robinson |
craig bot
pushed a commit
that referenced
this pull request
May 12, 2018
25428: ui: add compaction/flushes to storage graphs r=a-robinson a=tschottdorf Knowing whether compactions are going on is helpful when diagnosing I/O performance problems. Release note (admin ui change): Add RocksDB compactions/flushes to storage graphs. Co-authored-by: Tobias Schottdorf <[email protected]>
Build succeeded |
craig bot
pushed a commit
that referenced
this pull request
May 14, 2018
25457: backport-2.0: ui: add compaction/flushes to storage graphs r=a-robinson a=tschottdorf Backport 1/1 commits from #25428. /cc @cockroachdb/release --- Knowing whether compactions are going on is helpful when diagnosing I/O performance problems. Release note (admin ui change): Add RocksDB compactions/flushes to storage graphs. Co-authored-by: Tobias Schottdorf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Knowing whether compactions are going on is helpful when diagnosing I/O
performance problems.
Release note (admin ui change): Add RocksDB compactions/flushes to
storage graphs.