Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rocksdb: use max_manifest_file_size option #25341

Merged
merged 1 commit into from
May 11, 2018
+6 −0
Merged

rocksdb: use max_manifest_file_size option #25341

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions c-deps/libroach/options.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,12 @@ rocksdb::Options DBMakeOptions(DBOptions db_opts) {
options.target_file_size_base = 4 << 20; // 4 MB
options.target_file_size_multiplier = 2;

// Because we open a long running rocksdb instance, we do not want the
// manifest file to grow unbounded. Assuming each manifest entry is about 1
// KB, this allows for 128 K entries. This could account for several hours to
// few months of runtime without rolling based on the workload.
options.max_manifest_file_size = 128 << 20; // 128 MB

rocksdb::BlockBasedTableOptions table_options;
if (db_opts.cache != nullptr) {
table_options.block_cache = db_opts.cache->rep;
Expand Down