cherrypick-2.0: cli: debug zip with timeout, added dump for crdb_internal.gossip_*
#25276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now made command `debug zip` continue past errors with a timeout (based on peter's timeout commit). Also dumped information in crdb_internal.gossip_nodes and gossip_liveness to the output file. Fixes cockroachdb#23954. Release note: None
|
This change is |
|
Review status: 0 of 3 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
|
bors r=bdarnell |
craig bot
pushed a commit
that referenced
this pull request
May 7, 2018
25276: cherrypick-2.0: cli: `debug zip` with timeout, added dump for crdb_internal.gossip_* r=bdarnell a=tschottdorf Now made command `debug zip` continue past errors with a timeout (based on peter's timeout commit). Also dumped information in crdb_internal.gossip_nodes and gossip_liveness to the output file. Fixes #23954. cc @cockroachdb/release Release note: None Co-authored-by: Victor Chen <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now made command
debug zipcontinue past errors with a timeout(based on peter's timeout commit).
Also dumped information in crdb_internal.gossip_nodes and gossip_liveness
to the output file.
Fixes #23954.
cc @cockroachdb/release
Release note: None