ui: identify cluster to segment on load #24996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue where a bounce will never send an identify event to Segment. Release note: None
|
This change is |
mrtracy
approved these changes
Apr 23, 2018
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Apr 23, 2018
24996: ui: identify cluster to segment on load r=couchand a=couchand Fixes an issue where a bounce will never send an identify event to Segment. Release note: None Co-authored-by: Andrew Couch <[email protected]>
Build succeeded |
craig bot
pushed a commit
that referenced
this pull request
May 14, 2018
25081: release-2.0: ui: identify cluster to segment on load r=couchand a=couchand Backport 1/1 commits from #24996. /cc @cockroachdb/release --- Fixes an issue where a bounce will never send an identify event to Segment. Release note: None Co-authored-by: Andrew Couch <[email protected]>
couchand
added a commit
to couchand/cockroach
that referenced
this pull request
Jul 3, 2018
In cockroachdb#24996 I accidentally moved the identify call rather than copying it, meaning we frequently failed to issue the identify. This fixes that by trying to identify on every page if we have not yet. Release note: None
couchand
added a commit
to couchand/cockroach
that referenced
this pull request
Jul 3, 2018
In cockroachdb#24996 I accidentally moved the identify call rather than copying it, meaning we frequently failed to issue the identify. This fixes that by trying to identify on every page if we have not yet. Release note: None
craig bot
pushed a commit
that referenced
this pull request
Jul 3, 2018
27126: opt: improve the appliedRule callback r=RaduBerinde a=RaduBerinde #### opt: allow distinguishing between norm/explore rules Release note: None #### opt: improve the appliedRule callback Improving the appliedRule callback to also pass the ordinal of the expression that the rule was applied on. Cleaning up the related logic and state in forcing_opt. Release note: None 27132: ui: make sure we identify the cluster r=couchand a=couchand In #24996 I accidentally moved the identify call rather than copying it, meaning we frequently failed to issue the identify. This fixes that by trying to identify on every page if we have not yet. Release note: None Co-authored-by: Radu Berinde <[email protected]> Co-authored-by: Andrew Couch <[email protected]>
craig bot
pushed a commit
that referenced
this pull request
Jul 9, 2018
27133: release-2.0: ui: make sure we identify the cluster r=couchand a=couchand Backport 1/1 commits from #27132. /cc @cockroachdb/release --- In #24996 I accidentally moved the identify call rather than copying it, meaning we frequently failed to issue the identify. This fixes that by trying to identify on every page if we have not yet. Release note: None Co-authored-by: Andrew Couch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where a bounce will never send an identify event to Segment.
Release note: None