cherrypick-1.1: give craig an avatar, move bors.toml into .github #24672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At present, when GitHub apps create commits, they don't show up with the app's avatar. A workaround is to commit with an e-mail address that has an associated gravatar. Release note: None
Just to keep the root of the project a little cleaner. Release note: None
|
This change is |
bdarnell
approved these changes
Apr 11, 2018
|
bors r+ |
Build failed |
|
unrelated acceptance test failure bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Apr 11, 2018
24672: cherrypick-1.1: give craig an avatar, move bors.toml into .github r=couchand a=couchand build: give craig an avatar At present, when GitHub apps create commits, they don't show up with the app's avatar. A workaround is to commit with an e-mail address that has an associated gravatar. build: move bors.toml into .github folder Just to keep the root of the project a little cleaner. --- I hadn't planned on cherry-picking this, but figured it's a reasonable test that the branch protection is set up correctly. cc: @cockroachdb/release @jordanlewis Co-authored-by: Andrew Couch <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build: give craig an avatar
At present, when GitHub apps create commits, they don't show up
with the app's avatar. A workaround is to commit with an e-mail
address that has an associated gravatar.
build: move bors.toml into .github folder
Just to keep the root of the project a little cleaner.
I hadn't planned on cherry-picking this, but figured it's a reasonable test that the branch protection is set up correctly.
cc: @cockroachdb/release @jordanlewis