Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ts: Initial TimeSeries TestModel. #24594

Merged
merged 1 commit into from
Apr 10, 2018

Conversation

mrtracy
Copy link
Contributor

@mrtracy mrtracy commented Apr 9, 2018

Creates a new "testmodel" package under "ts" which contains an in-memory
test model designed to be much more conceptually simple than the
optimized query engine actually used by time series.

The new test model stores time series in sorted arrays as full-fidelity
nanosecond data points. It then uses a highly decomposed set of
functions to process that data; these functions have been designed to be
individually tested.

The "Query" method shows an example of how simple this system is when
compared to the actual time series system, which uses iterators and
breaks up queries into multiple chunks.

This model has not yet been hooked up to time series tests; it will soon
be used to replace the existing test model, which is not easier to
understand than the actual time series database.

@mrtracy mrtracy requested a review from bdarnell April 9, 2018 04:47
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@bdarnell
Copy link
Contributor

bdarnell commented Apr 9, 2018

:lgtm:


Review status: 0 of 4 files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@mrtracy
Copy link
Contributor Author

mrtracy commented Apr 9, 2018

bors r-

@mrtracy
Copy link
Contributor Author

mrtracy commented Apr 9, 2018

Missed the fact that lint failed, sorry

bors r-

@craig
Copy link
Contributor

craig bot commented Apr 9, 2018

Canceled

@mrtracy mrtracy force-pushed the mtracy/ts_test_model_overhaul branch from 759423b to 29e940e Compare April 9, 2018 19:22
Creates a new "testmodel" package under "ts" which contains an in-memory
test model designed to be much more conceptually simple than the
optimized query engine actually used by time series.

The new test model stores time series in sorted arrays as full-fidelity
nanosecond data points. It then uses a highly decomposed set of
functions to process that data; these functions have been designed to be
individually tested.

The "Query" method shows an example of how simple this system is when
compared to the actual time series system, which uses iterators and
breaks up queries into multiple chunks.

This model has not yet been hooked up to time series tests; it will soon
be used to replace the existing test model, which is *not* easier to
understand than the actual time series database.
@mrtracy mrtracy force-pushed the mtracy/ts_test_model_overhaul branch from 29e940e to 0d3d76a Compare April 9, 2018 19:29
@mrtracy
Copy link
Contributor Author

mrtracy commented Apr 10, 2018

bors r+

@craig
Copy link
Contributor

craig bot commented Apr 10, 2018

Build failed

@mrtracy
Copy link
Contributor Author

mrtracy commented Apr 10, 2018

bors r+

craig bot pushed a commit that referenced this pull request Apr 10, 2018
24594: ts: Initial TimeSeries TestModel. r=mrtracy a=mrtracy

Creates a new "testmodel" package under "ts" which contains an in-memory
test model designed to be much more conceptually simple than the
optimized query engine actually used by time series.

The new test model stores time series in sorted arrays as full-fidelity
nanosecond data points. It then uses a highly decomposed set of
functions to process that data; these functions have been designed to be
individually tested.

The "Query" method shows an example of how simple this system is when
compared to the actual time series system, which uses iterators and
breaks up queries into multiple chunks.

This model has not yet been hooked up to time series tests; it will soon
be used to replace the existing test model, which is *not* easier to
understand than the actual time series database.

Co-authored-by: Matt Tracy <[email protected]>
@craig
Copy link
Contributor

craig bot commented Apr 10, 2018

Build succeeded

@craig craig bot merged commit 0d3d76a into cockroachdb:master Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants