-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ts: Initial TimeSeries TestModel. #24594
Merged
craig
merged 1 commit into
cockroachdb:master
from
mrtracy:mtracy/ts_test_model_overhaul
Apr 10, 2018
Merged
ts: Initial TimeSeries TestModel. #24594
craig
merged 1 commit into
cockroachdb:master
from
mrtracy:mtracy/ts_test_model_overhaul
Apr 10, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review status: 0 of 4 files reviewed at latest revision, all discussions resolved, some commit checks failed. Comments from Reviewable |
bors r- |
Missed the fact that lint failed, sorry bors r- |
Canceled |
mrtracy
force-pushed
the
mtracy/ts_test_model_overhaul
branch
from
April 9, 2018 19:22
759423b
to
29e940e
Compare
Creates a new "testmodel" package under "ts" which contains an in-memory test model designed to be much more conceptually simple than the optimized query engine actually used by time series. The new test model stores time series in sorted arrays as full-fidelity nanosecond data points. It then uses a highly decomposed set of functions to process that data; these functions have been designed to be individually tested. The "Query" method shows an example of how simple this system is when compared to the actual time series system, which uses iterators and breaks up queries into multiple chunks. This model has not yet been hooked up to time series tests; it will soon be used to replace the existing test model, which is *not* easier to understand than the actual time series database.
mrtracy
force-pushed
the
mtracy/ts_test_model_overhaul
branch
from
April 9, 2018 19:29
29e940e
to
0d3d76a
Compare
bors r+ |
Build failed |
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Apr 10, 2018
24594: ts: Initial TimeSeries TestModel. r=mrtracy a=mrtracy Creates a new "testmodel" package under "ts" which contains an in-memory test model designed to be much more conceptually simple than the optimized query engine actually used by time series. The new test model stores time series in sorted arrays as full-fidelity nanosecond data points. It then uses a highly decomposed set of functions to process that data; these functions have been designed to be individually tested. The "Query" method shows an example of how simple this system is when compared to the actual time series system, which uses iterators and breaks up queries into multiple chunks. This model has not yet been hooked up to time series tests; it will soon be used to replace the existing test model, which is *not* easier to understand than the actual time series database. Co-authored-by: Matt Tracy <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a new "testmodel" package under "ts" which contains an in-memory
test model designed to be much more conceptually simple than the
optimized query engine actually used by time series.
The new test model stores time series in sorted arrays as full-fidelity
nanosecond data points. It then uses a highly decomposed set of
functions to process that data; these functions have been designed to be
individually tested.
The "Query" method shows an example of how simple this system is when
compared to the actual time series system, which uses iterators and
breaks up queries into multiple chunks.
This model has not yet been hooked up to time series tests; it will soon
be used to replace the existing test model, which is not easier to
understand than the actual time series database.