-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
distsqlrun: add NoopProcessor benchmark #24477
Conversation
Release note: None
Review status: 0 of 3 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
Reviewed 1 of 2 files at r1. pkg/sql/distsqlrun/noop_test.go, line 31 at r2 (raw file):
I think you can just embed this in pkg/sql/distsqlrun/noop_test.go, line 52 at r2 (raw file):
Probably good to be consistent here and extract the Comments from Reviewable |
Review status: 1 of 3 files reviewed at latest revision, 2 unresolved discussions, some commit checks pending. pkg/sql/distsqlrun/noop_test.go, line 31 at r2 (raw file): Previously, asubiotto (Alfonso Subiotto Marqués) wrote…
Nevermind, didn't see the use in Comments from Reviewable |
Can you include the benchmark results (using Review status: 1 of 3 files reviewed at latest revision, 2 unresolved discussions, some commit checks pending. Comments from Reviewable |
Here are the results (updated the PR description as well):
|
``` name time/op Noop/cols=1-8 3.23ms ± 2% Noop/cols=2-8 4.56ms ± 2% Noop/cols=4-8 6.53ms ± 5% Noop/cols=16-8 23.4ms ± 2% Noop/cols=256-8 407ms ± 6% name speed Noop/cols=1-8 162MB/s ± 2% Noop/cols=2-8 230MB/s ± 2% Noop/cols=4-8 321MB/s ± 5% Noop/cols=16-8 359MB/s ± 2% Noop/cols=256-8 331MB/s ± 5% ``` Release note: None
15476e3
to
5a2cc78
Compare
Review status: 1 of 3 files reviewed at latest revision, 2 unresolved discussions. pkg/sql/distsqlrun/noop_test.go, line 52 at r2 (raw file): Previously, asubiotto (Alfonso Subiotto Marqués) wrote…
Done. Comments from Reviewable |
Review status: 1 of 3 files reviewed at latest revision, 2 unresolved discussions, some commit checks pending. Comments from Reviewable |
bors r+ |
24477: distsqlrun: add NoopProcessor benchmark r=jordanlewis a=jordanlewis It's nice to be able to see how fast the DistSQL processor interface itself is. ``` name time/op Noop/cols=1-8 3.23ms ± 2% Noop/cols=2-8 4.56ms ± 2% Noop/cols=4-8 6.53ms ± 5% Noop/cols=16-8 23.4ms ± 2% Noop/cols=256-8 407ms ± 6% name speed Noop/cols=1-8 162MB/s ± 2% Noop/cols=2-8 230MB/s ± 2% Noop/cols=4-8 321MB/s ± 5% Noop/cols=16-8 359MB/s ± 2% Noop/cols=256-8 331MB/s ± 5% ```
Build succeeded |
It's nice to be able to see how fast the DistSQL processor interface itself is.