ui: Add per-node option to Custom Graphs #23771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
mrtracy
changed the title
mrtracy
force-pushed
the
mtracy/custom_graph_new_options
branch
from
4108c01 to
8592691
Compare
|
This is cool — tried locally and it works good 👍 Starting to remind me of honeycomb.io's query editor: The "breakdown" value of 999 seems a little weird; maybe we can wrap aggregation/breakdown in another type? Any thoughts @couchand? Aside: reduces the need for #23733… Maybe we should link from the current graphs to "broken-down" graphs here. |
|
Capturing in-person discussion: would prefer a separate column with a checkbox that says "per-node" (or something), instead of "breakdown" as an aggregation option with a sentinel value. That'd be more discoverable to users, and gets rid of sentinel value awkwardness. |
mrtracy
force-pushed
the
mtracy/custom_graph_new_options
branch
from
8592691 to
bd62bcd
Compare
|
Updated with suggestion (also updated commit message).
|
vilterp
changed the title
vilterp
approved these changes
Mar 14, 2018
Adds "Per Node" option to custom graphs, which will graph a separate line for every node in the cluster for a given metric. Also fixes a bug where you could not graph multiple lines of the same named metric. Release note: None
mrtracy
force-pushed
the
mtracy/custom_graph_new_options
branch
from
bd62bcd to
b96ab02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds "Breakdown" aggregator option to custom graphs, which will graph a
separate line for every node in the cluster for a given metric.
Also fixes a bug where you could not graph multiple lines of the same
named metric.
Release note: None