cherrypick-1.1: storage: transfer raft leadership and wait grace period when draining #23306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Review status: 0 of 5 files reviewed at latest revision, all discussions resolved, some commit checks failed. Comments from Reviewable |
The previous version of getRaftLeader would not return the leader if all replicas had the same term and the leader wasn't the first to be iterated over. Release note: None
|
Removed the commit with |
Previously, even though a draining replica would transfer its lease, when it came to `leasePostApply`, the raft leadership would not be transferred because the target was not up-to-date enough. This would result in the draining replica taking the leadership with it and producing a zero qps scenario until a new election was held after an election timeout. This change adds a draining flag to a replica so that it may skip this check. A draining store will also wait for a minimum of 5s after transferring away all of its replica's leases to allow for the raft leadership change to take place. Addresses #22573. Release note (bug fix): Fix a zero qps scenario when a node would be gracefully drained.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#22767