Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: consider node unhealthy when liveness status is not LIVE #22502

Merged
merged 1 commit into from
Feb 8, 2018
Merged

server: consider node unhealthy when liveness status is not LIVE #22502

merged 1 commit into from
Feb 8, 2018

Conversation

asubiotto
Copy link
Contributor

Issue #22424 brought to light the fact that a load balancer using
the /health endpoint would not consider draining nodes unhealthy, and
would route requests to it. This is the first step to ensuring that load
balancers do not route requests to draining nodes.

Release note (bug fix): Health endpoint now returns a node as unhealthy
when draining or decommissioning.

Issue #22424 brought to light the fact that a load balancer using
the /health endpoint would not consider draining nodes unhealthy, and
would route requests to it. This is the first step to ensuring that load
balancers do not route requests to draining nodes.

Release note (bug fix): Health endpoint now returns a node as unhealthy
when draining or decommissioning.
@asubiotto asubiotto requested review from bdarnell and a team February 8, 2018 16:05
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@bdarnell
Copy link
Contributor

bdarnell commented Feb 8, 2018

:lgtm:


Review status: 0 of 2 files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

@asubiotto asubiotto merged commit be32749 into cockroachdb:master Feb 8, 2018
@asubiotto asubiotto deleted the drain-health branch February 8, 2018 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants