Convert gossip's capacity key to store key
#2239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the word "convert" snuck into the commit message one time too many. LGTM |
|
It did indeed. Fixed. |
|
You didn't change the commit message, though. |
We actually gossip the full store.description (which includes the capacity), so there's no reason to call it only capacity. This also includes * Change the key suffix from nodeID-storeID to just storeID * Renaming of the gossip capacity functions to gossip store.
BramGruneir
force-pushed
the
bram/gossip
branch
from
cddd0d4 to
9edd75f
Compare
|
You're too fast for me. |
|
zoom |
BramGruneir
added a commit
that referenced
this pull request
Aug 24, 2015
Convert gossip's `capacity` key to `store` key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We actually gossip the full store.description (which includes the capacity), so there's no reason to call it only capacity.
This also includes