Give SQL transactions a debug name #2233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM Shouldn't be difficult to pass a debug name from the client and/or allow |
| @@ -218,8 +219,9 @@ func (s *Server) execStmt(stmt parser.Statement, req driver.Request, planMaker * | |||
| // Start a transaction here and not in planMaker to prevent begin | |||
| // transaction from being called within an auto-transaction below. | |||
| planMaker.txn = client.NewTxn(*s.db) | |||
| planMaker.txn.SetDebugName("sql", 0) | |||
There was a problem hiding this comment.
Could we set this to the explained plan instead? That'd be a lot more useful.
There was a problem hiding this comment.
What plan? This is getting set at the moment of BEGIN coming in, which doesn't really do any work.
|
LGTM |
tamird
added a commit
that referenced
this pull request
Aug 25, 2015
Give SQL transactions a debug name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just "sql" for now.
Easier to review commit-by-commit, first one is cleanup.