Convert PrefixConfig to a proto
#2151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // PrefixConfig relates a string prefix to a config object. | ||
| // PrefixConfig objects are the constituents of PrefixConfigMap | ||
| // objects. In order to support binary searches of hierarchical | ||
| // prefixes (see the comments in NewPrefixConfigMap), PrefixConfig |
There was a problem hiding this comment.
can you add which file the newprefixconfigmap is in?
There was a problem hiding this comment.
heh, that's not even the right name any more! fixing.
There was a problem hiding this comment.
err, nm, it is the right name
|
LGTM |
tamird
added a commit
that referenced
this pull request
Aug 18, 2015
Convert `PrefixConfig` to a proto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1966.