storage: Eagerly GC dormant replicas when decommissioning #17304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Reviewed 1 of 1 files at r1. Comments from Reviewable |
a-robinson
added a commit
to tbg/cockroach
that referenced
this pull request
Aug 1, 2017
Tests the fix in cockroachdb#17304 for issue cockroachdb#17288
tbg
pushed a commit
to tbg/cockroach
that referenced
this pull request
Aug 3, 2017
Tests the fix in cockroachdb#17304 for issue cockroachdb#17288
tbg
pushed a commit
to tbg/cockroach
that referenced
this pull request
Aug 4, 2017
Tests the fix in cockroachdb#17304 for issue cockroachdb#17288
tbg
pushed a commit
to tbg/cockroach
that referenced
this pull request
Aug 4, 2017
Tests the fix in cockroachdb#17304 for issue cockroachdb#17288
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17288
The ideal test for this is to add on to the acceptance test in #17272 to
Without this patch, it gets stuck because the replicas don't get GC'ed. With this patch, it finishes quickly. Want me to write the test and add it on top of #17272?