-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vendor: update grpc-go #14939
vendor: update grpc-go #14939
Conversation
The motivation behind this update is to include andreimatei/grpc-go@ded79a3 which avoids having one RPC hog the connection and allows for a decent number of RPCs on the same connection. Some DistSQL queries were hanging because of some RPCs being blocked on the consumption of other RPCs which couldn't use the connection to progress.
Is there an issue which describe the specific deadlock scenario that is being encountered? I'm interested in understanding more precisely what is going on here. It seems like the deadlock can still occur and could have occurred even with the original gRPC window settings. That makes this change a bit of a kludge (which I'm perfectly ok with in the short term). |
Here's the issue #14948. It does let me keep on running TPC-H queries and having the connection window size be a multiple of the RPC window size is probably a good idea in general. |
Looks like you'll have to fix a typo while you're here: |
Will submit a separate PR for that. I'm kind of confused though, it seems like the typo has been around for a few months? |
Your update picked up an unrelated update to the spellcheck linter and it started noticing it. |
I wouldn't bother with a separate PR.
…On Fri, Apr 14, 2017 at 5:15 PM, David Taylor ***@***.***> wrote:
Your update picked up an unrelated update to the spellcheck linter and it
started noticing it.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#14939 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABdsPFEEyH8yrrtxGh5qvJYy7wlwy4vxks5rv-IKgaJpZM4M-AEa>
.
|
Review status: 0 of 4 files reviewed at latest revision, all discussions resolved, some commit checks failed. Comments from Reviewable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm looking forward to testing this out!
The motivation behind this update is to include andreimatei/grpc-go@ded79a3
which avoids having one RPC hog the connection and allows for a
decent number of RPCs on the same connection. Some DistSQL queries
were hanging because of some RPCs being blocked on the consumption of
other RPCs which couldn't use the connection to progress.