migrations: Clean up main_test file #14665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Fix merge skew and remove unnecessary bits.
|
definitely LGTM for the security assets part since it wouldn't even build. |
|
The idea is to more closely match the main_test.go file to rpc/main_test.go (another package that the server package depends on) and put main_test.go into the same package as migration_test.go. I think this is how it should have been in the first place. |
|
ok. LGTM on this bit too. |
|
I'm not sure what's going on with the check failures though. |
|
This builder looks borked. Did someone run a build with an ancient builder image? |
|
How do we reset it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe this messiness influenced the weird failure in #14655?
Fixes #14655