sql/parser: move pg builtins to their own file #14494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They're all categoryCompatibility, so set that in a loop rather than one by one.
jordanlewis
force-pushed
the
pg-builtins
branch
from
bb231b8 to
d486568
Compare
knz
approved these changes
Mar 31, 2017
|
it was indeed. TFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having the Postgres builtins all sit in
builtins.gowas getting messy. Now they all live in a new file,pg_builtins.go.Soon we will need to add a lot more compatibility builtins to handle #13470 and #12526. These will be generated automatically, but it'll be clearer if all of that functionality lives in this new file, similar to how the aggregate builtin generators live in their own file.
This change is