-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-25.1.0-rc: upgrades: lock rows before backfilling them during upgrade #141461
release-25.1.0-rc: upgrades: lock rows before backfilling them during upgrade #141461
Conversation
Release note (bug fix): A step in the 25.1 upgrade finalization process that required backfilling jobs now uses locks to ensure it makes progress even when there is contention on the jobs table to prevent the possibility of becoming stuck under heavy load. Epic: none.
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
( |
FYI: I'm going to backfill "Fixes #140967", so that our [newly enabled!] "fix version mapping" system links this backport and issue to v25.1.0. |
Backport 1/1 commits from #141420 on behalf of @dt.
/cc @cockroachdb/release
Release note (bug fix): A step in the 25.1 upgrade finalization process that required backfilling jobs now uses locks to ensure it makes progress even when there is contention on the jobs table to prevent the possibility of becoming stuck under heavy load.
Fixes: #140967
Epic: none.
Release justification: fixes a bug that can in some conditions prevent an upgrade from 25.1 from finalizing, which makes it a potentially severe bug.