distsqlrun: remove redundant Close() #14103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Close() is already called when timedOut is set. fixes cockroachdb#13989
|
Needs a test. |
|
I don't think this needs a test. |
|
LGTM, thanks for fixing! |
|
This needed a test because the bug made apparent that we don't have any tests exercising a stream connection timeout. Sent out #14132. Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, all commit checks successful. Comments from Reviewable |
|
Thanks!
…On Mon, Mar 13, 2017 at 10:42 PM Andrei Matei ***@***.***> wrote:
This needed a test because the bug made apparent that we don't have any
tests exercising a stream connection timeout. Sent out #14132
<#14132>.
------------------------------
Review status: 0 of 1 files reviewed at latest revision, all discussions
resolved, all commit checks successful.
------------------------------
*Comments from Reviewable
<https://reviewable.io:443/reviews/cockroachdb/cockroach/14103#-:-Kf9gB2NWJIksP46tYHz:b-koro7z>*
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#14103 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALOpBLxs3aYMTVl7s3GxT84GBZaaS8e6ks5rlf53gaJpZM4MavwS>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close() is already called when timedOut is set.
fixes #13989
This change is