upgrades: remove redundant ensureSQLSchemaTelemetrySchedule permanent upgrade

[shubhamdhama]

During startup, CreateSchemaTelemetrySchedule, which creates the scheduled job to collect schema telemetry, is redundantly invoked twice concurrently: once via schematelemetrycontroller.Controller.Start and also through the ensureSQLSchemaTelemetrySchedule permanent upgrade.

This was identified in #119340, where the permanent upgrade encounters contention and is resolved nearly 30 seconds later causing slow startup of the tenant. Although the exact reason for the prolonged transaction deadlock is unclear, we can still benefit by removing this redundant upgrade.

Informs: #119340
Closes: #130931

Release note: None

Epic: none

[cockroach-teamcity]

This change is 

[rafiss]

Nice find! It seems like this test also confirms that the schedule is created upon startup:

cockroach/pkg/sql/catalog/schematelemetry/schema_telemetry_test.go

Line 74 in 9f61a38

func TestSchemaTelemetrySchedule(t *testing.T) {

[stevendanna]

Thanks for taking this on!

Let's keep an eye on this post merge. At test cluster startup, we still have something of a thundering herd of servers trying to create the telemetry schedule. Moving it out of the permanent upgrades means the contention won't delay startup, but it is still a little unfortunate that we have all of these processes spinning trying to create this simple record.

[shubhamdhama]

Sure! I'll keep an eye on this.

bors r=rafiss

[craig]

Build succeeded:

• macos_arm64_build
• check_generated_code
• local_roachtest_fips
• local_roachtest
• macos_amd64_build
• acceptance
• linux_arm64_build
• docker_image_amd64
• unit_tests
• lint
• linux_amd64_build
• windows_build
• examples_orms
• linux_amd64_fips_build

[iskettaneh]

blathers backport 25.1

[blathers-crl]

Based on the specified backports for this PR, I applied new labels to the following linked issue(s). Please adjust the labels as needed to match the branches actually affected by the issue(s), including adding any known older branches.

---

Issue #130931: branch-release-25.1.

---

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}