roachprod-microbench: influx fails on missing benchmark #138902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herkolategan
requested review from
golgeek and
DarrylWong
and removed request for
a team
|
This change is |
DarrylWong
approved these changes
Jan 13, 2025
srosenberg
reviewed
Jan 14, 2025
| @@ -466,6 +466,9 @@ func (c *compare) pushToInfluxDB() error { | |||
| } | |||
|
|
|||
| for idx, benchmarkName := range cs.Benchmarks { | |||
| if len(cs.Summaries) == 0 { | |||
| continue | |||
There was a problem hiding this comment.
Given that it's an exceptional case, should a warning be logged, to facilitate debugging?
There was a problem hiding this comment.
Good idea, I'll add logging before merging.
Previously, the push to influx operation did not handle the case where it could not compute a summary between two runs due to a missing or renamed benchmark. This change adds a check to skip over the benchmark if no summaries are found. Epic: None Release note: None
herkolategan
force-pushed
the
hbl/roachprod-microbench-influx-fix
branch
from
ea92e22 to
752e9d6
Compare
|
TFTRs! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jan 20, 2025
138902: roachprod-microbench: influx fails on missing benchmark r=herkolategan a=herkolategan Previously, the push to influx operation did not handle the case where it could not compute a summary between two runs due to a missing or renamed benchmark. This change adds a check to skip over the benchmark if no summaries are found. Epic: None Release note: None Co-authored-by: Herko Lategan <[email protected]>
|
Build failed: |
|
bors retry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the push to influx operation did not handle the case where it could not compute a summary between two runs due to a missing or renamed benchmark. This change adds a check to skip over the benchmark if no summaries are found.
Epic: None
Release note: None