backup: cut user and table counts in cluster backup test #138087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was creating 1k users and 100 tables, altering 100 tables and dropping 100 tables in both the system and tenent branches. This many schema change jobs made the test very, very slow and sensitive to schema changer delays adding up. In one recently observed CI run, creating the 1000 users took upwards of nine minutes -- for a single test's setup, before it even started testing the actual backup feature it is supposed to test. This changes the user counts and table counts to be much smaller, hopefully reducing the number of schema changes and waits on schema changes that are involved in setting up this test. Release note: none. Epic: none.
|
This change is |
|
tftr! bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was creating 1k users and 100 tables, altering 100 tables and dropping 100 tables in both the system and tenent branches. This many schema change jobs made the test very, very slow and sensitive to schema changer delays adding up. In one recently observed CI run, creating the 1000 users took upwards of nine minutes -- for a single test's setup, before it even started testing the actual backup feature it is supposed to test.
This changes the user counts and table counts to be much smaller, hopefully reducing the number of schema changes and waits on schema changes that are involved in setting up this test.
Release note: none.
Epic: none.