Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvserver/rangefeed: metamorphically enable RangefeedUseBufferedSender #136995

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

wenyihu6
Copy link
Contributor

@wenyihu6 wenyihu6 commented Dec 9, 2024

kvserver/rangefeed: rename .buffered_stream_sender. to .buffered_sender.

This patch renames kv.rangefeed.buffered_stream_sender.enabled to
kv.rangefeed.buffered_sender.enabled to align with variable and
struct names better.

Epic: none
Release: none


kvserver/rangefeed: metamorphically enable RangefeedUseBufferedSender

This patch metamorphically enables the cluster setting
RangefeedUseBufferedSender.

Release note: none
Part of: #135332

Copy link

blathers-crl bot commented Dec 9, 2024

Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link

blathers-crl bot commented Dec 9, 2024

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@wenyihu6 wenyihu6 force-pushed the metamorphic branch 2 times, most recently from 75d17a0 to e4e1375 Compare December 9, 2024 12:26
@wenyihu6
Copy link
Contributor Author

wenyihu6 commented Dec 9, 2024

How do we feel about lifting the restriction here

settings.WithValidateBool(func(_ *settings.Values, b bool) error {
if buildutil.CrdbTestBuild || !b {
return nil
}
return ErrBufferedSenderNotSupported
}),
?

Update: seems fine to leave it for now given roachtests do not use metamorphic constants https://cockroachlabs.slack.com/archives/C023S0V4YEB/p1733846019532919.

…ender.*

This patch renames kv.rangefeed.buffered_stream_sender.enabled to
kv.rangefeed.buffered_sender.enabled to align with variable and
struct names better.

Epic: none
Release: none
@wenyihu6 wenyihu6 marked this pull request as ready for review December 10, 2024 18:50
@wenyihu6 wenyihu6 requested a review from a team as a code owner December 10, 2024 18:50
@wenyihu6 wenyihu6 requested review from stevendanna and removed request for a team December 10, 2024 18:50
Copy link
Collaborator

@stevendanna stevendanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This patch metamorphically enables the cluster setting
RangefeedUseBufferedSender.

Release note: none
Part of: cockroachdb#135332
@wenyihu6
Copy link
Contributor Author

wenyihu6 commented Dec 12, 2024

TFTR!

bors r=stevendanna

@wenyihu6
Copy link
Contributor Author

Extended CI failure TestLogGrowthWhenRefreshingPendingCommands looks unrelated.

@craig craig bot merged commit 43fe07f into cockroachdb:master Dec 12, 2024
21 of 22 checks passed
@wenyihu6 wenyihu6 deleted the metamorphic branch December 12, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants