-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kvserver/rangefeed: metamorphically enable RangefeedUseBufferedSender #136995
Conversation
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
75d17a0
to
e4e1375
Compare
How do we feel about lifting the restriction here cockroach/pkg/kv/kvserver/replica_rangefeed.go Lines 102 to 107 in a907659
Update: seems fine to leave it for now given roachtests do not use metamorphic constants https://cockroachlabs.slack.com/archives/C023S0V4YEB/p1733846019532919. |
13eed58
to
2346d31
Compare
…ender.* This patch renames kv.rangefeed.buffered_stream_sender.enabled to kv.rangefeed.buffered_sender.enabled to align with variable and struct names better. Epic: none Release: none
2346d31
to
5d908a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This patch metamorphically enables the cluster setting RangefeedUseBufferedSender. Release note: none Part of: cockroachdb#135332
5d908a4
to
e273e83
Compare
TFTR! bors r=stevendanna |
Extended CI failure TestLogGrowthWhenRefreshingPendingCommands looks unrelated. |
kvserver/rangefeed: rename .buffered_stream_sender. to .buffered_sender.
This patch renames kv.rangefeed.buffered_stream_sender.enabled to
kv.rangefeed.buffered_sender.enabled to align with variable and
struct names better.
Epic: none
Release: none
kvserver/rangefeed: metamorphically enable RangefeedUseBufferedSender
This patch metamorphically enables the cluster setting
RangefeedUseBufferedSender.
Release note: none
Part of: #135332