kvserver: write ForceFlushIndex and integrate with RAC2 #136330
Conversation
…geController This is used to set the highest index up to which all send-queues in pull mode must be force-flushed. Informs cockroachdb#135601 Epic: CRDB-37515 Release note: None
- ReplicatedEvalResult.DoTimelyApplicationToAllReplicas is added and set in splitTriggerHelper, MergeTrigger, Migrate, Subsume. - The previous setting to true is gated on cluster version V25_1_AddRangeForceFlushKey. - This causes ReplicaState.ForceFlushIndex to be set, and RangeForceFlushKey (a replicated range-id local key) to be written when applying the corresponding batch to the state machine. The index is set to the index of the entry being applied, and is monotonically increasing. - replica_rac2.Processor and rac2.RangeController have existing ForceFlushIndexChangedLocked methods that are called whenever the Replica sees a change in the force-flush-index. Fixes cockroachdb#135601 Epic: CRDB-37515 Release note: None
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
There was a problem hiding this comment.
This is a small change. The first commit is from #136321
@kvoli There is no unit testing of whether the ForceFlushIndex is properly plumbed to the rangeController when updated, or when the Replica is initialized using a snapshot. Once your split/merge/migrate tests are merged, I think we can modify them to also introspect the state of rangeController to see that it has a ForceFlushIndex that is advancing. We could also create a new replica in one of those tests and check that the ForceFlushIndex in that replica is the same as the others. Thoughts?
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @kvoli and @pav-kv)
in splitTriggerHelper, MergeTrigger, Migrate, Subsume.
V25_1_AddRangeForceFlushKey.
RangeForceFlushKey (a replicated range-id local key) to be written when
applying the corresponding batch to the state machine. The index is set
to the index of the entry being applied, and is monotonically
increasing.
existing ForceFlushIndexChangedLocked methods that are called whenever
the Replica sees a change in the force-flush-index.
Fixes #135601
Epic: CRDB-37515
Release note: None