Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-24.3: sql: apply PCR AOST time stamp for authentication flow #136327

Merged
merged 2 commits into from
Nov 29, 2024
Merged

release-24.3: sql: apply PCR AOST time stamp for authentication flow #136327

merged 2 commits into from
Nov 29, 2024

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Nov 27, 2024 •
edited by fqazi
Loading

Backport 2/2 commits from #135929 on behalf of @fqazi.

/cc @cockroachdb/release

Previously, when using PCR reader catalog its was possible to hit "PCR reader timestamp has moved forward" when attempting to execute workloads. This was because internal executors are exempt from the AOST timestamp. To address this, the authentication code paths are updated to set fixed timestamps, when connecting to a PCR reader catalog. Additionally, additional tests are added for validating opening new connections and preparing queries to confirm this problem is fixed.

Fixes: #135829

Release note: None

Release justification: bug fix for an issue that can make PCR user catalog unusable if frequent timestamp updates occur

fqazi added 2 commits November 20, 2024 20:33
@fqazi
sql: apply PCR AOST time stamp for authentication flow
a8fa34e 
Previously, when using PCR reader catalog its was possible to hit "PCR
reader timestamp has moved forward" when attempting to execute
workloads. This was because internal executors are exempt from the AOST
timestamp. To address this, the authentication code paths are updated to
set fixed timestamps, when connecting to a PCR reader catalog.
Additionally, additional tests are added for validating opening new
connections and preparing queries to confirm this problem is fixed.

Fixes: #135829

Release note: None
@fqazi
catalog/lease: mismatchedExternalDataRowTimestamp retryable
a635eac 
Previously, when mixed ExternalDataRow time stamps were detected between
descriptors during a txn, an error would be returned. While user
operations should never see this error because of an AOST set on them
(to guarantee a consistent view of descriptors), internal operations
could observe this error. To address this, this patch marks the
mismatchedExternalDataRowTimestamp error as retryable. This will cause
internal txns to retry if the error gets hit.

Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner November 27, 2024 22:58
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Nov 27, 2024
@blathers-crl blathers[crl]
Copy link
Author

blathers-crl bot commented Nov 27, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues     or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot requested review from dt, fqazi, msbutler and rafiss November 27, 2024 22:58
@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Nov 27, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@fqazi fqazi merged commit ab59e84 into release-24.3 Nov 29, 2024
20 of 21 checks passed
@fqazi fqazi deleted the blathers/backport-release-24.3-135929 branch November 29, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafiss rafiss rafiss approved these changes

@dt dt Awaiting requested review from dt

@fqazi fqazi Awaiting requested review from fqazi

@msbutler msbutler Awaiting requested review from msbutler

Assignees

@fqazi fqazi

Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @rafiss @fqazi