-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-24.2: kvclient: prevent MuxRangeFeed call from hanging #136282
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rangefeedMuxer holds a cache of `muxStreamOrError`. If the initial MuxRangeFeed call fails, the error is cached rather than a working client. That failure would be cached forever, and future attempts to initiate a rangefeed on that particular node would then return the cached error. If all replicas for a particular range failed in this way, the rangefeed would hang forever, continuously "retrying" but only ever encountering the cached error. Here, we remove items from the cache on error. Epic: none Release note: None
518ecfb
to
42a9b97
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
wenyihu6
approved these changes
Dec 16, 2024
Reminder: it has been 3 weeks please merge or close your backport! |
24.2 branch is being locked down since it was the innovation release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport
Label PR's that are backports to older release branches
blathers-backport
This is a backport that Blathers created automatically.
no-backport-pr-activity
O-robot
Originated from a bot.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #134776 on behalf of @stevendanna.
/cc @cockroachdb/release
The rangefeedMuxer holds a cache of
muxStreamOrError
. If the initial MuxRangeFeed call fails, the error is cached rather than a working client. That failure would be cached forever, and future attempts to initiate a rangefeed on that particular node would then return the cached error.If all replicas for a particular range failed in this way, the rangefeed would hang forever, continuously "retrying" but only ever encountering the cached error.
Here, we remove items from the cache on error.
Epic: none
Release note: None
Release justification: