Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.2: kvclient: prevent MuxRangeFeed call from hanging #136282

Closed

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Nov 27, 2024

Backport 1/1 commits from #134776 on behalf of @stevendanna.

/cc @cockroachdb/release


The rangefeedMuxer holds a cache of muxStreamOrError. If the initial MuxRangeFeed call fails, the error is cached rather than a working client. That failure would be cached forever, and future attempts to initiate a rangefeed on that particular node would then return the cached error.

If all replicas for a particular range failed in this way, the rangefeed would hang forever, continuously "retrying" but only ever encountering the cached error.

Here, we remove items from the cache on error.

Epic: none
Release note: None


Release justification:

The rangefeedMuxer holds a cache of `muxStreamOrError`. If the initial
MuxRangeFeed call fails, the error is cached rather than a working
client. That failure would be cached forever, and future attempts to
initiate a rangefeed on that particular node would then return the
cached error.

If all replicas for a particular range failed in this way, the
rangefeed would hang forever, continuously "retrying" but only ever
encountering the cached error.

Here, we remove items from the cache on error.

Epic: none
Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner November 27, 2024 10:01
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-24.2-134776 branch from 518ecfb to 42a9b97 Compare November 27, 2024 10:01
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Nov 27, 2024
@blathers-crl blathers-crl bot requested a review from stevendanna November 27, 2024 10:01
Copy link
Author

blathers-crl bot commented Nov 27, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot requested a review from wenyihu6 November 27, 2024 10:01
@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Nov 27, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link

github-actions bot commented Jan 7, 2025

Reminder: it has been 3 weeks please merge or close your backport!

@yuzefovich
Copy link
Member

24.2 branch is being locked down since it was the innovation release

@yuzefovich yuzefovich closed this Feb 15, 2025
@yuzefovich yuzefovich deleted the blathers/backport-release-24.2-134776 branch February 15, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. no-backport-pr-activity O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants