Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.3: ui: fix bug where index details page link is broken in cc console #135993

Merged

Conversation

kyle-a-wong
Copy link
Contributor

Backport 1/1 commits from #135941.

/cc @cockroachdb/release

This PR includes a version bump of cluster-ui


Fixes the url used in cc console when clicking on an index from the table details index tab. This bug only affects clusters in version 24.3.

Also changes the index details page breadcrumbs to always render the same breadcrumb, always linking to the new databases pages. There is no longer a need define seperate logic for CC console and db console because both have converged to the same path definitions for the databases, database details, and table details pages.

Lastly, this commit fixes a small bug that exists in the legacy BreadCrumb component that can cause bread crumb links to disappear due to the modification of the component prop using, using .pop() on the items array.

Part of: #135857
Epic: none
Release note: none

Fixes the url used in cc console when clicking on an index from
the table details index tab. This bug only affects clusters in
version 24.3.

Also changes the index details page breadcrumbs to always render
the same breadcrumb, always linking to the new databases pages.
There is no longer a need define seperate logic for CC console
and db console because both have converged to the same path
definitions for the databases, database details, and table
details pages.

Lastly, this commit fixes a small bug that exists in the legacy
BreadCrumb component that can cause bread crumb links to
disappear due to the modification of the component prop using,
using .pop() on the items array.

Part of: cockroachdb#135857
Epic: none
Release note: none
Epic: none
Release note: none
@kyle-a-wong kyle-a-wong requested a review from a team as a code owner November 22, 2024 15:21
@kyle-a-wong kyle-a-wong requested review from dhartunian and removed request for a team November 22, 2024 15:21
Copy link

blathers-crl bot commented Nov 22, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Nov 22, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@kyle-a-wong kyle-a-wong merged commit a915efc into cockroachdb:release-24.3 Nov 22, 2024
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants