schemachanger: remove subzone fallbacks #135918
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
This comment was marked as outdated.
This comment was marked as outdated.
|
This change is |
annrpom
force-pushed
the
remove-subzone-fallbacks
branch
5 times, most recently
from
faa0d78
to
4d02e1d
Compare
This patch avoids using yaml syntax for zone configs in some tests as it becomes deprecated in the DSC. Epic: none Release note: None
Epic: none Release note: None
annrpom
force-pushed
the
remove-subzone-fallbacks
branch
from
4d02e1d
to
cf81883
Compare
annrpom
force-pushed
the
remove-subzone-fallbacks
branch
from
cf81883
to
09e98b0
Compare
This logic is no longer needed. Epic: none Release note: None
Previously, we would hit a panic if we tried setting the zone config on an index that had a temp index from a backfill. This panic was caused from an incorrect assumption that there would only be 1 `IndexName` during the backfill. This patch ensures that we filter out by the current status of `PUBLIC` -- which should guarantee uniqueness. Epic: none Release note: None
annrpom
force-pushed
the
remove-subzone-fallbacks
branch
3 times, most recently
from
36f53a5
to
f68b9bd
Compare
Fixes: cockroachdb#130900 Release note: None
annrpom
force-pushed
the
remove-subzone-fallbacks
branch
from
f68b9bd
to
03b73d2
Compare
|
I'll add a test for the 4th commit, but opening for any comments. Re: what we discussed in our tech discussion: I realized we needed a RBR fallback in drop index before we can have that test go down the DSC path |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for details.
Fixes: #130900
Release note: None