-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-24.2: sql/catalog/bootstrap: don't call PrefixEnd on tenant start key #131279
Merged
stevendanna
merged 1 commit into
release-24.2
from
blathers/backport-release-24.2-131208
Oct 17, 2024
Merged
release-24.2: sql/catalog/bootstrap: don't call PrefixEnd on tenant start key #131279
stevendanna
merged 1 commit into
release-24.2
from
blathers/backport-release-24.2-131208
Oct 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KVServer expects that split keys have a valid tenant prefix. Calling PrefixEnd() on the start key to a tenant does not produce a valid key as the tenant ID is encoded as a varint. Epic: none Release note: None
7a7ea87
to
ac7713c
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
jeffswenson
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reminder: it has been 3 weeks please merge or close your backport! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport
Label PR's that are backports to older release branches
blathers-backport
This is a backport that Blathers created automatically.
no-backport-pr-activity
O-robot
Originated from a bot.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #131208 on behalf of @stevendanna.
/cc @cockroachdb/release
KVServer expects that split keys have a valid tenant prefix. Calling PrefixEnd() on the start key to a tenant does not produce a valid key as the tenant ID is encoded as a varint.
Epic: none
Release note: None
Release justification: Low risk bug fix for tenant-creation stopping bug