kvserver: remove StoreBenignError #130308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. I have added a few people who may be able to assist in reviewing:
🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
blathers-crl
bot
added
O-community
|
This change is |
tbg
requested changes
Sep 9, 2024
XiaochenCui
force-pushed
the
kvserver-129941
branch
from
10b967c to
94afbc9
Compare
|
Thank you for updating your pull request. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
test |
Before commit 3f0b37a, the StoreBenignError is used to handle pebble.ErrSnapshotExcised. As the latter has been removed from pebble, we don't need StoreBenignError anymore. This commit does the following: - Remove type "StoreBenignError". - Remove the related increase action on counter "storeFailures". - Update related tests "TestBaseQueueRequeue". Fixes: cockroachdb#129941 Release note: None
XiaochenCui
force-pushed
the
kvserver-129941
branch
from
94afbc9 to
dd32bc1
Compare
XiaochenCui
commented
Sep 10, 2024
|
Thank you! I'm rebasing this over in #139150 (had some difficulties pushing to the fork). |
craig bot
pushed a commit
that referenced
this pull request
Jan 21, 2025
139150: kvserver: remove StoreBenignError r=tbg a=tbg Before commit 3f0b37a, the StoreBenignError is used to handle pebble.ErrSnapshotExcised. As the latter has been removed from pebble, we don't need StoreBenignError anymore. This commit does the following: - Remove type "StoreBenignError". - Remove the related increase action on counter "storeFailures". - Update related tests "TestBaseQueueRequeue". Fixes: #129941 Closes: #130308 Release note: None 139280: roachtest: adding backup/restore tests for minio r=sravotto a=sravotto Introducing a test to verify that we can backup and restore into a Minio Object Store cluster, using S3 API. Fixes: #139272 Release note: None 139333: roachtest: only run 30 node backfill tests in full ac mode r=andrewbaptist a=andrewbaptist In the non-full AC modes, a node can OOM during the fill period and the test will fail. This impacts the perturbation/metamorphic/backfill test. Fixes: #139302 Informs: #139319 Release note: None 139475: rangefeed: fix test logging r=tbg a=stevendanna The logging didn't actually print the value as it seemed to intend. Informs #119340 Release note: None Co-authored-by: XiaochenCui <[email protected]> Co-authored-by: Tobias Grieger <[email protected]> Co-authored-by: Silvano Ravotto <[email protected]> Co-authored-by: Andrew Baptist <[email protected]> Co-authored-by: Steven Danna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before commit 3f0b37a, the
StoreBenignErroris used to handlepebble.ErrSnapshotExcised. As the latter has been removed from pebble, we don't needStoreBenignErroranymore.This commit does the following:
Fixes: #129941
Release note: None
Deprecation of
benignerror.NewStoreBenign:3f0b37a#diff-7052dadbb62a54f17fe2ab2ea16258a8e225f89e0670342b00c82ea80935bee8
Deprecation of
pebble.ErrSnapshotExcised:cockroachdb/pebble@1d7852b#diff-0bdcb7129d4d3bd87c0a2d883a50d310991a7bc4ae4b8ab311d63072bde219a8