roachprod: update roachprod-gc.yaml with azure-subscription-names flag #129371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
DarrylWong
force-pushed
the
roachprod-gc-update
branch
from
6307862 to
4f1eee6
Compare
DarrylWong
commented
Aug 21, 2024
| @@ -10,7 +10,7 @@ | |||
| # --from-literal azure_password=XYZZY | |||
| # --from-literal azure_tenant_id=XYZZY | |||
| # --from-literal slack_token=XYZZY | |||
| apiVersion: batch/v1beta1 | |||
| apiVersion: batch/v1 | |||
There was a problem hiding this comment.
https://kubernetes.io/docs/reference/using-api/deprecation-guide/
The batch/v1beta1 API version of CronJob is no longer served as of v1.25.
Migrate manifests and API clients to use the batch/v1 API version, available since v1.21.
DarrylWong
requested review from
herkolategan and
nameisbhaskar
and removed request for
a team
srosenberg
approved these changes
Aug 21, 2024
This enables roachprod to clean up multiple subscriptions.
herkolategan
approved these changes
Aug 22, 2024
DarrylWong
force-pushed
the
roachprod-gc-update
branch
from
4f1eee6 to
5c83036
Compare
|
Updated with the new docker image. TFTRs! bors r=srosenberg,herkolategan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables roachprod to clean up multiple subscriptions.
Fixes: none
Release note: none
Epic: none