roachtest: cdc/mixed-versions support for shared-process deployments #128473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renatolabs
requested review from
nameisbhaskar and
DarrylWong
and removed request for
a team
|
This change is |
srosenberg
reviewed
Aug 8, 2024
srosenberg
reviewed
Aug 8, 2024
| @@ -401,6 +402,10 @@ func (cmvt *cdcMixedVersionTester) runWorkloadCmd(r *rand.Rand) *roachtestutil.C | |||
| func (cmvt *cdcMixedVersionTester) initWorkload( | |||
| ctx context.Context, l *logger.Logger, r *rand.Rand, h *mixedversion.Helper, | |||
| ) error { | |||
| if err := enableTenantSplitScatter(l, r, h); err != nil { | |||
There was a problem hiding this comment.
Nit: seems arbitrary here, but I get why it's needed. Maybe the planner can automatically enable this for multi-tenant scenarios?
There was a problem hiding this comment.
Hrmm, maybe, but some tests work fine without it -- it's only needed for tests that invoke workloads that perform split/scatter. For now I think having tests call this helper function explicitly is fine.
This commit updates the `cdc/mixed-versions` test so that it is able to run on a shared-process deployment. Specifically, it updates the changefeed creator to take two connections: one to the tenant being tested (which could be the system tenant as well), and one to the system tenant. The latter is used to set cluster settings that are only visible to the system tenant and control how changefeeds work. Informs: cockroachdb#127378 Release note: None
`enthropy` -> `entropy` Epic: none Release note: None
renatolabs
force-pushed
the
rc/mixedversion-cdc-shared-process-support
branch
from
49c0d72 to
9afac09
Compare
renatolabs
added
backport-24.1.x
|
TFTR! bors r=srosenberg |
This was referenced Aug 8, 2024
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the
cdc/mixed-versionstest so that it is able to run on a shared-process deployment. Specifically, it updates the changefeed creator to take two connections: one to the tenant being tested (which could be the system tenant as well), and one to the system tenant. The latter is used to set cluster settings that are only visible to the system tenant and control how changefeeds work.Informs: #127378
Release note: None