rangefeed: fix sendMetadata deadlock #123519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the rangefeed client's context is cancelled before a metadata event is sent on the event channel, the rangefeed could hang forever. This bug was introduced in cockroachdb#123001. Fixes cockroachdb#123355 Fixes cockroachdb#123397 Release note: none
Epic: none Release note: none
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
msbutler
added
backport-24.1.x
|
FYI that I'm removing the backport to v24.1.0-rc, as the rc candidate is building now. thanks! |
dt
approved these changes
May 3, 2024
|
The issue affects 24.1 and 24.1.0 as well, but I think we can live with it in 24.1.0 |
|
TFTR! bors r=dt |
|
Build failed:
|
|
unrelated unit test flake bors r+ |
|
blathers backport release-24.1.0-rc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the rangefeed client's context is cancelled before a metadata event is sent
on the event channel, the rangefeed could hang forever. This bug was introduced
in #123001.
Fixes #123355
Fixes #123397
Release note: none