Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: sql: add FORCE_INVERTED_INDEX hint #122301

Merged
merged 3 commits into from
Apr 14, 2024

Conversation

mgartner
Copy link
Collaborator

@mgartner mgartner commented Apr 12, 2024

Backport 3/4 commits from #120384.

/cc @cockroachdb/release


sql/parser: move index hint tests to new file

This is purely a mechanical movement of parser tests with index hints
into a new file.

Release note: None

sql/parser: support FORCE_INVERTED_INDEX hint

This commit adds parsing support for the FORCE_INVERTED_INDEX hint. The
hint currently has no effect.

Release note: None

sql: support FORCE_INVERTED_INDEX hint

Epic: None

Release note (sql change): The FORCE_INVERTED_INDEX hint is now
supported. This makes the optimizer prefer a query plan scan over any
inverted index of the hinted table. The query will result in an error if
no such query plan can be generated.


Release justification: This is a new feature that must be opted into.

This is purely a mechanical movement of parser tests with index hints
into a new file.

Release note: None
This commit adds parsing support for the `FORCE_INVERTED_INDEX` hint. The
hint currently has no effect.

Release note: None
Release note (sql change): The `FORCE_INVERTED_INDEX` hint is now
supported. This makes the optimizer prefer a query plan scan over any
inverted index of the hinted table. The query will result in an error if
no such query plan can be generated.
@mgartner mgartner requested review from a team as code owners April 12, 2024 17:58
@mgartner mgartner requested review from DrewKimball and removed request for a team April 12, 2024 17:58
Copy link

blathers-crl bot commented Apr 12, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Apr 12, 2024
@mgartner mgartner requested a review from rytaft April 12, 2024 17:58
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@DrewKimball DrewKimball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, 4 of 4 files at r2, 8 of 8 files at r3, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @rytaft)

Copy link
Collaborator

@rytaft rytaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, 4 of 4 files at r2, 8 of 8 files at r3, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @mgartner)

@mgartner mgartner merged commit 5bccb34 into cockroachdb:release-23.1 Apr 14, 2024
6 checks passed
@mgartner mgartner deleted the backport23.1-120384 branch April 14, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants