-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.1: sql: add FORCE_INVERTED_INDEX hint #122301
release-23.1: sql: add FORCE_INVERTED_INDEX hint #122301
Conversation
This is purely a mechanical movement of parser tests with index hints into a new file. Release note: None
This commit adds parsing support for the `FORCE_INVERTED_INDEX` hint. The hint currently has no effect. Release note: None
Release note (sql change): The `FORCE_INVERTED_INDEX` hint is now supported. This makes the optimizer prefer a query plan scan over any inverted index of the hinted table. The query will result in an error if no such query plan can be generated.
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, 4 of 4 files at r2, 8 of 8 files at r3, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @rytaft)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, 4 of 4 files at r2, 8 of 8 files at r3, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @mgartner)
Backport 3/4 commits from #120384.
/cc @cockroachdb/release
sql/parser: move index hint tests to new file
This is purely a mechanical movement of parser tests with index hints
into a new file.
Release note: None
sql/parser: support FORCE_INVERTED_INDEX hint
This commit adds parsing support for the
FORCE_INVERTED_INDEX
hint. Thehint currently has no effect.
Release note: None
sql: support FORCE_INVERTED_INDEX hint
Epic: None
Release note (sql change): The
FORCE_INVERTED_INDEX
hint is nowsupported. This makes the optimizer prefer a query plan scan over any
inverted index of the hinted table. The query will result in an error if
no such query plan can be generated.
Release justification: This is a new feature that must be opted into.