-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql: add some missing postgres vars for ORM compatibility #12149
Conversation
90222a4
to
b5ec958
Compare
Review status: 0 of 5 files reviewed at latest revision, 3 unresolved discussions, all commit checks successful. pkg/sql/set.go, line 126 at r1 (raw file):
should we return an error if anything but UTF-8 is specified? pkg/sql/set.go, line 134 at r1 (raw file):
should we return an error or log a warning if an attempt is made to set to disable this? what happens if a client sets this to pkg/sql/set.go, line 135 at r1 (raw file):
This is the right page: Comments from Reviewable |
This commit adds no-op support for the following variables, to improve ORM compatability: - `SEARCH_PATH` - `CLIENT_ENCODING` - `STANDARD_CONFORMING_STRINGS` - `CLIENT_MIN_MESSAGES`
b5ec958
to
ee2dfac
Compare
TFTR! Review status: 0 of 5 files reviewed at latest revision, 3 unresolved discussions, all commit checks successful. pkg/sql/set.go, line 126 at r1 (raw file): Previously, cuongdo (Cuong Do) wrote…
I suppose that would be nice of us, yes. Done. pkg/sql/set.go, line 134 at r1 (raw file): Previously, cuongdo (Cuong Do) wrote…
Done. pkg/sql/set.go, line 135 at r1 (raw file): Previously, cuongdo (Cuong Do) wrote…
Done. Comments from Reviewable |
Review status: 0 of 5 files reviewed at latest revision, 3 unresolved discussions, some commit checks pending. pkg/sql/set.go, line 126 at r1 (raw file): Previously, jordanlewis (Jordan Lewis) wrote…
Can you also add a test for the error case? pkg/sql/set.go, line 134 at r1 (raw file): Previously, jordanlewis (Jordan Lewis) wrote…
Could you add a test for the error case? pkg/sql/set.go, line 151 at r3 (raw file):
nit: Comments from Reviewable |
ee2dfac
to
2a55240
Compare
Review status: 0 of 5 files reviewed at latest revision, 3 unresolved discussions. pkg/sql/set.go, line 126 at r1 (raw file): Previously, cuongdo (Cuong Do) wrote…
Done. pkg/sql/set.go, line 134 at r1 (raw file): Previously, cuongdo (Cuong Do) wrote…
Done. pkg/sql/set.go, line 151 at r3 (raw file): Previously, cuongdo (Cuong Do) wrote…
Simplified this case. Comments from Reviewable |
Review status: 0 of 5 files reviewed at latest revision, 3 unresolved discussions, all commit checks successful. Comments from Reviewable |
In the future, when we have a docs page collecting session variables, these might be included. |
This PR adds no-op support for setting the following variables, to improve ORM compatability:
SEARCH_PATH
CLIENT_ENCODING
STANDARD_CONFORMING_STRINGS
CLIENT_MIN_MESSAGES
It also adds support for
SHOW SERVER_VERSION
, always returning the9.5.0
postgres version that we return overpgwire
.Resolves #12137
Resolves #12134
Resolves #12113
Resolves #12109
Resolves #12112
This change is