telemetryccl: use log spy in backup/restore test #120646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhartunian
requested review from
ZhouXing19,
a team and
abarganier
and removed request for
a team
|
This change is |
abarganier
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @dhartunian and @ZhouXing19)
pkg/ccl/telemetryccl/telemetry_logging_test.go line 167 at r1 (raw file):
var rawLog logpb.Entry if err := json.Unmarshal(entry, &rawLog); err != nil { return
nit: should we try logging something if we fail to unmarshal here and the two places below?
Code quote:
return
Previously this test used file logging to test the telemetry output, which can result in flakes on CI. This commit modifies the test to use a log spy which is a bit more reliable. Additionally, the deserialization now happens in the `Intercept()` method which makes the test easier to read. Resolves: cockroachdb#120115 Epic: None Release note: None
dhartunian
force-pushed
the
telemetry-logging-job-test
branch
from
1223fe4 to
cffcc30
Compare
dhartunian
commented
Mar 19, 2024
There was a problem hiding this comment.
Reviewable status:
pkg/ccl/telemetryccl/telemetry_logging_test.go line 167 at r1 (raw file):
Previously, abarganier (Alex Barganier) wrote…
nit: should we try logging something if we fail to unmarshal here and the two places below?
Done.
|
bors r=abarganier |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this test used file logging to test the telemetry output, which can result in flakes on CI. This commit modifies the test to use a log spy which is a bit more reliable. Additionally, the deserialization now happens in the
Intercept()method which makes the test easier to read.Resolves: #120115
Epic: None
Release note: None