sql,backupccl: create IMPORT ROLLBACK job in online restore #120407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevendanna
requested review from
dt,
jbowens and
mgartner
and removed request for
a team
|
This change is |
stevendanna
force-pushed
the
import-epoch-predicate-job
branch
4 times, most recently
from
4cf9126 to
1615358
Compare
msbutler
reviewed
Mar 20, 2024
| } | ||
|
|
||
| func (r *importRollbackResumer) OnFailOrCancel(context.Context, interface{}, error) error { | ||
| return errors.AssertionFailedf("OnFailOrCancel called on non-cancellable job %d", r.job.ID()) |
There was a problem hiding this comment.
i may have missed this somewhere: do you have to flag in job creation or in the job constructor that this job is non-cancellable?
There was a problem hiding this comment.
Good catch, added the bool to the job record.
stevendanna
force-pushed
the
import-epoch-predicate-job
branch
2 times, most recently
from
23d69f7 to
1a032c9
Compare
Yeah, I semantically merged-conflicted with myself. |
msbutler
approved these changes
Mar 20, 2024
| exec-sql | ||
| BACKUP INTO 'nodelocal://1/cluster/'; | ||
| ---- | ||
|
|
||
|
|
||
| new-cluster name=s2 share-io-dir=s1 allow-implicit-access disable-tenant | ||
| new-cluster name=s2 allow-implicit-access disable-tenant |
There was a problem hiding this comment.
nit: no need to use a new cluster. this test was written before prefix synthesis.
pkg/ccl/backupccl/testdata/backup-restore/online-restore-in-progress-imports
Outdated
Show resolved
Hide resolved
stevendanna
force-pushed
the
import-epoch-predicate-job
branch
2 times, most recently
from
d955392 to
1ed770f
Compare
|
bors r=msbutler |
|
Build failed: |
Tables that are offline and have a non-zero ImportEpoch are now restored to their offline state and an IMPORT ROLLBACK job is synthesized. The IMPORT ROLLBACK job uses an epoch-based predicate delete to rollback the table and bring it back online. Epic: none Release note: None
stevendanna
force-pushed
the
import-epoch-predicate-job
branch
from
1ed770f to
f2790a1
Compare
|
bors r=msbutler |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tables that are offline and have a non-zero ImportEpoch are now restored to their offline state and an IMPORT
ROLLBACK job is synthesized.
The IMPORT ROLLBACK job uses an epoch-based predicate delete to
rollback the table and bring it back online.
Epic: none
Release note: None