lint: various fixes and improvements #119893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rickystewart
force-pushed
the
fix-lint-stuff
branch
from
6988b23 to
edf3f29
Compare
1. Use code generation to remove the `lint` build tag for running lints. On the Bazel side, you're not likely to accidentally run these tests and build tags just slow things down. 2. Fix the script for the nightly lint to exit with the correct status code and generate code before running. 3. Fix some lint errors in `lint_test.go` itself. Epic: none Release note: None
rickystewart
force-pushed
the
fix-lint-stuff
branch
from
edf3f29 to
feba0c7
Compare
|
bors r=rail |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lintbuild tag for running lints.On the Bazel side, you're not likely to accidentally run these tests
and build tags just slow things down.
code and generate code before running.
lint_test.goitself.Epic: none
Release note: None