Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ttljob: skip TestSpanToQueryBoundsCompositeKeys under stress #119519

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

annrpom
Copy link
Contributor

@annrpom annrpom commented Feb 22, 2024

This patch skips TestSpanToQueryBoundsCompositeKeys under stress/stressrace as it often hits OOM issues under these conditions.

Epic: none

Release note: None

This patch skips TestSpanToQueryBoundsCompositeKeys under
stress/stressrace as it often hits OOM issues under these
conditions.

Epic: none

Release note: None
@annrpom annrpom requested a review from a team as a code owner February 22, 2024 15:50
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@fqazi fqazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @annrpom)


pkg/sql/ttl/ttljob/ttljob_processor_test.go line 227 at r1 (raw file):

	defer leaktest.AfterTest(t)()
	defer log.Scope(t).Close(t)

If deadlock modes also run into trouble we may want skip.UnderDuress()

@annrpom
Copy link
Contributor Author

annrpom commented Feb 22, 2024

flake brought up here

These tests are failing with

test_server_shim.go:159: automatically injected an external process virtual cluster under test; see comment at top of test_server_shim.go for details.

as the only fail state (i.e. there are no other error messages). This is typically indicative of an OOM.


If deadlock modes also run into trouble we may want skip.UnderDuress()

Tried to navigate engflow/TC to determine if this is the case - I don't believe it is

@annrpom
Copy link
Contributor Author

annrpom commented Feb 22, 2024

TFTR! ('-')7

bors r=fqazi

@craig
Copy link
Contributor

craig bot commented Feb 22, 2024

Build succeeded:

@craig craig bot merged commit 9e52705 into cockroachdb:master Feb 22, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants