Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.2: workload/tpcc: optionally disable txn retry loops #119268

Merged

Conversation

nvanbenschoten
Copy link
Member

@nvanbenschoten nvanbenschoten commented Feb 15, 2024

Backport 1/1 commits from #117096.

/cc @cockroachdb/release


Informs #115191.

This commit adds a --txn-retries flag to tpcc, allowing users of the workload to disable transaction retry loops for 40001 errors.

For Serializable transactions (controllable with --isolation-level), this quickly leads to errors being thrown by the workload. For Read Committed transaction, the workload eventually hits an error due to a lease transfer. Combined with a prototype fix for #61986, Read Committed transactions survive for at least a few minutes without error.

Release note: None

Release justification: workload only.

Informs cockroachdb#115191.

This commit adds a `--txn-retries` flag to `tpcc`, allowing users of the
workload to disable transaction retry loops for 40001 errors.

For Serializable transactions (controllable with `--isolation-level`),
this quickly leads to errors being thrown by the workload. For Read
Committed transaction, the workload eventually hits an error due to
a lease transfer. Combined with a prototype fix for cockroachdb#61986, Read
Committed transactions survive for at least a few minutes without
error.

Release note: None
@nvanbenschoten nvanbenschoten requested a review from a team as a code owner February 15, 2024 21:41
@nvanbenschoten nvanbenschoten requested review from herkolategan and srosenberg and removed request for a team February 15, 2024 21:41
Copy link

blathers-crl bot commented Feb 15, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Feb 15, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@nvanbenschoten nvanbenschoten merged commit 2711ab9 into cockroachdb:release-23.2 Feb 20, 2024
5 of 6 checks passed
@nvanbenschoten nvanbenschoten deleted the backport23.2-117096 branch March 4, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants