-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.2.1-rc: server, ui: set HttpOnly: true
and Secure
flags on cookies
#119249
Merged
dhartunian
merged 2 commits into
cockroachdb:release-23.2.1-rc
from
dhartunian:23.2-cookie-settings-fixes
Feb 15, 2024
Merged
release-23.2.1-rc: server, ui: set HttpOnly: true
and Secure
flags on cookies
#119249
dhartunian
merged 2 commits into
cockroachdb:release-23.2.1-rc
from
dhartunian:23.2-cookie-settings-fixes
Feb 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
blathers-crl
bot
added
the
backport
Label PR's that are backports to older release branches
label
Feb 15, 2024
stevendanna
approved these changes
Feb 15, 2024
dhartunian
changed the title
release-23.2.1-rc: server, ui: set HttpOnly: true and Secure flags on cookies
release-23.2.1-rc: server, ui: set Feb 15, 2024
HttpOnly: true
and Secure
flags on cookies
abarganier
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 1 of 0 LGTMs obtained
This change removes the ability of the DB Console JS code to read the `session` cookie from the browser by setting the `HttpOnly` flag to `true`. This change requires a modification of how the `TenantDropdown` components works since it relied on reading the `session` cookie and extracting the list of logged-in tenants from it. Instead of reading the cookie, the component now relies on a server- side endpoint to "read back" the list of tenants in the session. You might ask why this is necessary because we could return the list of valid tenants on `/login` success and have them available outright. There is a reason why that's not sufficient. When you are logged in to multiple tenants with a valid session, you can switch between them in the dropdown switcher. This switch occurs without a subsequent call to `/login`, and will just set the `tenant` cookie to the new tenant name and issue a full refresh to the browser which will re-render everything. In this case, the `TenantDropdown` component gets fully re-rendered but no longer has access to the state it was initialized with containing all the valid tenants. This necessitates adding an endpoint that the component can use to populate itself directly whenever it's rendered. Epic: None Fixes: CRDB-36034 Release note (security update): DB Console `session` cookie is now marked `HttpOnly` to prevent it from being read by any Javascript code.
Cookie `Secure` setting is based on `disableTLSForHTTP` passed down from the server. Part of CRDB-36034 Epic: None Release note (security update): DB Console cookies are marked `Secure` for the browser when the cluster is running in secure mode.
dhartunian
force-pushed
the
23.2-cookie-settings-fixes
branch
from
February 15, 2024 19:05
50998f5
to
77b6afb
Compare
dhartunian
merged commit Feb 15, 2024
898cd6a
into
cockroachdb:release-23.2.1-rc
4 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
server, ui: session cookie is HttpOnly
This change removes the ability of the DB Console JS code to read
the
session
cookie from the browser by setting theHttpOnly
flagto
true
.This change requires a modification of how the
TenantDropdown
components works since it relied on reading the
session
cookie andextracting the list of logged-in tenants from it.
Instead of reading the cookie, the component now relies on a server-
side endpoint to "read back" the list of tenants in the session. You
might ask why this is necessary because we could return the list of
valid tenants on
/login
success and have them available outright.There is a reason why that's not sufficient.
When you are logged in to multiple tenants with a valid session, you
can switch between them in the dropdown switcher. This switch occurs
without a subsequent call to
/login
, and will just set thetenant
cookie to the new tenant name and issue a full refresh to the browser
which will re-render everything. In this case, the
TenantDropdown
component gets fully re-rendered but no longer has access to the
state it was initialized with containing all the valid tenants. This
necessitates adding an endpoint that the component can use to populate
itself directly whenever it's rendered.
Epic: None
Fixes: CRDB-36034
Release note (security update): DB Console
session
cookie is nowmarked
HttpOnly
to prevent it from being read by any Javascriptcode.
server: set Secure on cookies if cluster is secure
Cookie
Secure
setting is based ondisableTLSForHTTP
passed downfrom the server.
Part of CRDB-36034
Epic: None
Release note (security update): DB Console cookies are marked
Secure
for the browser when the cluster is running in secure mode.
Release justification: high-priority need for fix