Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: stop ignoring activerecord failures #118581

Merged
merged 1 commit into from
Feb 3, 2024
Merged

roachtest: stop ignoring activerecord failures #118581

merged 1 commit into from
Feb 3, 2024

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Feb 1, 2024

The adapter has been stabilized, so we should enable this test again.

fixes #108938
Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss
Copy link
Collaborator Author

rafiss commented Feb 1, 2024

testing here: https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_Nightlies_RoachtestNightlyGceBazel/13787422?hideProblemsFromDependencies=false&hideTestsFromDependencies=false

@rafiss
roachtest: stop ignoring activerecord failures
217319d 
The adapter has been stabilized, so we should enable this test again.

Release note: None
@rafiss rafiss force-pushed the enable-activerecord branch from 2dab2fc to 217319d Compare February 1, 2024 21:20
@rafiss
Copy link
Collaborator Author

rafiss commented Feb 1, 2024

a second run: https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_Nightlies_RoachtestNightlyGceBazel/13794102?hideProblemsFromDependencies=false&hideTestsFromDependencies=false

@rafiss rafiss marked this pull request as ready for review February 2, 2024 01:44
@rafiss rafiss requested review from a team as code owners February 2, 2024 01:44
@rafiss rafiss requested review from herkolategan, srosenberg, a team and annrpom and removed request for a team February 2, 2024 01:44
annrpom
annrpom approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@annrpom annrpom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rafiss
Copy link
Collaborator Author

rafiss commented Feb 2, 2024

tftr!

bors r+

@craig
Copy link
Contributor

craig bot commented Feb 2, 2024

This PR was included in a batch that was canceled, it will be automatically retried

@craig craig bot merged commit d3af62d into cockroachdb:master Feb 3, 2024
9 checks passed
@craig
Copy link
Contributor

craig bot commented Feb 3, 2024

Build succeeded:

@rafiss rafiss deleted the enable-activerecord branch February 3, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annrpom annrpom annrpom approved these changes

@herkolategan herkolategan Awaiting requested review from herkolategan herkolategan was automatically assigned from cockroachdb/test-eng

@srosenberg srosenberg Awaiting requested review from srosenberg srosenberg was automatically assigned from cockroachdb/test-eng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

roachtest: update to stable activerecord test suite when available
3 participants
@rafiss @cockroach-teamcity @annrpom