release-23.1: rangefeed: add TestProcessorContextCancellation
#118412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tests that async tasks spawned by the rangefeed processor are cancelled when the processor shuts down, via context cancellation. Epic: none Release note: None
|
This change is |
erikgrinaker
changed the title
TestProcessorContextCancellationTestProcessorContextCancellation
nvanbenschoten
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of a #117612 backport.
This issue only affects the new scheduler-based rangefeed processor in 23.2 (off by default), the legacy processor handled this properly. This is a test-only backport demonstrating this.
Backport 0/2 commits from #117859.
Release justification: test improvement.
/cc @cockroachdb/release
This tests that async tasks spawned by the rangefeed processor are cancelled when the processor shuts down, via context cancellation.
Epic: none
Release note: None