Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bench: ignore cluster startup and shutdown #117872

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

yuzefovich
Copy link
Member

This commit adjusts our benchmark harness to ignore the overhead of starting up and shutting down the test cluster. This allows us to avoid spurious "regressions" like that we've seen due to #117116.

Epic: None

Release note: None

This commit adjusts our benchmark harness to ignore the overhead of
starting up and shutting down the test cluster. This allows us to avoid
spurious "regressions" like that we've seen due to cockroachdb#117116.

Epic: None

Release note: None
@yuzefovich yuzefovich added backport-23.1.x Flags PRs that need to be backported to 23.1 backport-23.2.x Flags PRs that need to be backported to 23.2. labels Jan 17, 2024
@yuzefovich yuzefovich requested review from mgartner and a team January 17, 2024 17:41
Copy link

blathers-crl bot commented Jan 17, 2024

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@yuzefovich
Copy link
Member Author

The impact of #117116 (which made the cluster shutdown much slower) is mentioned here. I picked one benchmark as a sanity check for this change, and it has the desired effect:

name                                          old time/op    new time/op    delta
WideTableIgnoreColumns/MultinodeCockroach-24     1.75s ± 4%     0.00s ± 1%  -99.79%  (p=0.000 n=10+9)

name                                          old alloc/op   new alloc/op   delta
WideTableIgnoreColumns/MultinodeCockroach-24    37.2MB ± 6%     2.3MB ± 1%  -93.78%  (p=0.000 n=9+10)

name                                          old allocs/op  new allocs/op  delta
WideTableIgnoreColumns/MultinodeCockroach-24      107k ± 1%        1k ± 1%  -98.73%  (p=0.000 n=8+9)

Copy link
Collaborator

@mgartner mgartner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuzefovich
Copy link
Member Author

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Jan 18, 2024

Build succeeded:

@craig craig bot merged commit c24aedd into cockroachdb:master Jan 18, 2024
8 of 9 checks passed
@yuzefovich yuzefovich deleted the fix-bench branch January 18, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1 backport-23.2.x Flags PRs that need to be backported to 23.2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants