sql: fix trigram inverted index on NAME type #117846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuzefovich
added
backport-23.1.x
|
This change is |
rytaft
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @mgartner and @yuzefovich)
pkg/sql/logictest/testdata/logic_test/trigram_indexes line 360 at r1 (raw file):
AS tab (col1_1, col1_2) ON (tab2.col1) = (tab.col1_1) AND (tab2.col2) = (tab.col1_2);
nit: remove tabs
Previously, we would hit an internal error when trying to use string-like datum of NAME type for the trigram inverted index. This data type is handled via the DOidWrapper around the DString, so we simply need to unwrap that. I decided to not include a release note given that we've only seen this issue once in our own randomized testing. Release note: None
yuzefovich
force-pushed
the
trigram-index-fix
branch
from
3077182 to
a120fff
Compare
yuzefovich
commented
Jan 17, 2024
There was a problem hiding this comment.
TFTR!
bors r+
Reviewable status:
|
Build succeeded: |
This was referenced Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would hit an internal error when trying to use string-like datum of NAME type for the trigram inverted index. This data type is handled via the DOidWrapper around the DString, so we simply need to unwrap that.
I decided to not include a release note given that we've only seen this issue once in our own randomized testing.
Fixes: #117758.
Release note: None