release-23.1: roachtest: assign adminui ports dynamically for virtual clusters

[blathers-crl]

Backport 2/2 commits from #117505 on behalf of @DarrylWong.

/cc @cockroachdb/release

---

This was originally removed in #115599 due to #114097 merging, but adminui was reverted in #117141 and mistakenly did not revert the special case for virtual clusters. We unskip the multitenant/distsql tests as well.

Release note: None
Fixes: #117150
Fixes: #117149
Epic: None

---

Release justification: Test only change

[blathers-crl]

Thanks for opening a backport.

Please check the backport criteria before merging:

• Backports should only be created for serious
  issues or test-only changes.
• Backports should not break backwards-compatibility.
• Backports should change as little code as possible.
• Backports should not change on-disk formats or node communication protocols.
• Backports should not add new functionality (except as defined
  here).
• Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
• All backports must be reviewed by the owning areas TL and one additional
  TL. For more information as to how that review should be conducted, please consult the backport
  policy.

If your backport adds new functionality, please ensure that the following additional criteria are satisfied:

• There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
• The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
• New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
• The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
• Your backport must be accompanied by a post to the appropriate Slack
  channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

[cockroach-teamcity]

This change is 

[DarrylWong]

This PR works as expected, setting the port dynamically, but the multitenant/distsql tests still fail.

It looks like --format json isn't supported as a table display format in 23.1, causing upsertVirtualClusterMetadata to error out. Even though this function was added a few months ago, it looks like it was never used until we switched to the new API.

I'm not too familiar with what the table display format is used for, so I'm not sure which format should be used instead of JSON. Actually I see now that we just parse it for the virtual cluster IDs 🤔

[renatolabs]

Ah, that's unfortunate. We could patch something up here, but I'm wondering if we should have the same logic across branches (and use something other than JSON to parse this data). Either way, this will introduce a bit of delay to this backport.

[renatolabs]

We can now bundle backports of #115599, #117505, and #117745 to 23.1 in a single PR and things should work.

[github-actions]

Reminder: it has been 3 weeks please merge or close your backport!

[DarrylWong]

I tried backporting all three in #117837 but running into more issues 😭

Trying to run the test locally gives me connection refused errors. I see that in 23.1 there is a local port offset to avoid local port collisions that isn't there on 23.2 and above.

cockroach/pkg/cmd/roachtest/tests/multitenant_distsql.go

Line 77 in ab9f165

localPortOffset = 1000

It seems to me that we need to also backport the fix for local port collisions as well, but I haven't dug around to find what exactly the fix is yet.

Running it on gce gets past that point, but it fails trying to collect stats with:

pq: rpc error: code = Unavailable desc = error reading from server: read tcp 10.142.0.5:44378->10.142.0.5:29004: read: connection reset by peer

I haven't had the chance to dig into what this error is either, but just commenting in case it rings a bell to anyone and to mention that this backport isn't forgotten, just running into some issues 😢

[github-actions]

Reminder: it has been 3 weeks please merge or close your backport!