roachtest: add mixed-version global table follower read test #117294
Conversation
nvanbenschoten
requested review from
herkolategan and
renatolabs
and removed request for
a team
|
This change is |
|
This would have caught the replica inconsistency described in #117302. |
nvanbenschoten
force-pushed
the
nvanbenschoten/mixedVersionGlobalTable
branch
from
75365bd to
84436b1
Compare
| mixedversion.NeverUseFixtures, | ||
| // Use a longer upgrade timeout to give the migrations enough time to finish | ||
| // considering the cross-region latency. | ||
| mixedversion.UpgradeTimeout(60*time.Minute), |
There was a problem hiding this comment.
Curious how long it takes today?
There was a problem hiding this comment.
The entire test takes about 80 minutes. I did see one instance where an upgrade migration timed out after 10m, so I'm conservatively bumping this up to give migrations more time.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @herkolategan, @renatolabs, and @srosenberg)
nvanbenschoten
added
backport-23.1.x
This commit adds a new mixed-version roachtest called `follower-reads/mixed-version/survival=region/locality=global/reads=strong`, which runs a multi-region follower-read test with a region-survivable global table while performing a cluster upgrade. Epic: None Release note: None
nvanbenschoten
force-pushed
the
nvanbenschoten/mixedVersionGlobalTable
branch
from
84436b1 to
895ebc7
Compare
|
TFTRs! Merging this as skipped because it will fail on master due to #117302. However, the test won't need to be skipped on release branches. bors r+ |
|
This PR was included in a batch that timed out, it will be automatically retried |
|
Build succeeded: |
This commit adds a new mixed-version roachtest called:
This test runs a multi-region follower-read test with a region-survivable global table while performing a cluster upgrade.
I'm adding this test to give us more confidence that we're not breaking anything when removing the synthetic timestamp bit in #101938.
Epic: None
Release note: None