kv,admission: only log empty admission warning for non-release builds #115705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
aadityasondhi
added
the
backport-23.2.x
sean-
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @erikgrinaker and @sumeerbhola)
aadityasondhi
force-pushed
the
20231206.remove-admission-header-warning
branch
from
64d07b2 to
f7d5357
Compare
|
I was missing the bazel import for |
erikgrinaker
approved these changes
Dec 6, 2023
This error message, while useful for debugging, spams the logs with a stack trace which can be distracting when reading the logs. Since AC defaults to skip when there is an empty header, this is not a concern, unless we see real-world performance impact (which we have not). This patch removes it from release builds while we figure out all the sources for missing headers. Informs cockroachdb#112680 Release note: None
aadityasondhi
force-pushed
the
20231206.remove-admission-header-warning
branch
from
f7d5357 to
943f747
Compare
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error message, while useful for debugging, spams the logs with a stack trace which can be distracting when reading the logs.
Since AC defaults to skip when there is an empty header, this is not a concern, unless we see real-world performance impact (which we have not).
This patch removes it from release builds while we figure out all the sources for missing headers.
Informs #112680
Release note: None