clusterversion: remove ByKey #115208
Merged
clusterversion: remove ByKey #115208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaduBerinde
requested review from
DarrylWong,
renatolabs,
jbowens,
msbutler and
miretskiy
and removed request for
a team
|
This change is |
Remove `ByKey`, replacing usage with `.Version()`. Epic: none Release note: None
RaduBerinde
force-pushed
the
cv-by-key-cleanup
branch
from
45712fb to
67d8be2
Compare
andyyang890
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
Reviewed 33 of 33 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @DarrylWong, @jbowens, @miretskiy, @msbutler, and @renatolabs)
|
TFTR! |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
ByKey, replacing usage with.Version().Epic: none
Release note: None
Informs #112629.