roachtest: bump timeout for hibernate tests #114378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hibernate tests are massive (11519 tests), and are slow. We are hitting against the default timeout of 3 hours, so this commit increases that to 4. Release note: None
rafiss
added
backport-23.1.x
rafiss
requested review from
srosenberg and
DarrylWong
and removed request for
a team
|
This change is |
DarrylWong
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Sorry if this was mentioned or obvious, but I think important context is that these tests were both metamorphic builds, which can and probably due slow down the test slightly.
It looks like both failures almost finished though (in the results checking phase) so bumping the timeout still seems like the right thing to do.
annrpom
approved these changes
Nov 13, 2023
|
tftr! bors r+ |
|
Build succeeded: |
This was referenced Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hibernate tests are massive (11519 tests), and are slow. We are hitting against the default timeout of 3 hours, so this commit increases that to 4.
fixes #114301
fixes #114136
Release note: None